Feature: Added support for Sync drive #16947
Open
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm unsure exactly how Sync cloud drive works, but since it's incredibly easy to implement I've done it based on what I understand from #16935 |
yaira2
reviewed
Mar 16, 2025
Lamparter
commented
Mar 16, 2025
| { | ||
| Name = $"Sync - {folder.Name}", | ||
| SyncFolder = directory, | ||
| // IconData = (needs icon) |
There was a problem hiding this comment.
There one in the install location C:\Program Files (x86)\Sync\folder.ico
| { | ||
| protected override async IAsyncEnumerable<ICloudProvider> GetProviders() | ||
| { | ||
| string syncFolderPath = Path.Combine(Constants.UserEnvironmentPaths.HomePath, "Sync"); |
There was a problem hiding this comment.
If you change the path in the installer, this would not work.
I think it would be better to modify the DetectGenericCloudDrive method. This method detects the existing cloud drives from the registry. I think that only small changes need to be made so that the SyncDrive is also recognized.
Lamparter
commented
Mar 20, 2025
| kDrive | ||
| kDrive, | ||
|
|
||
| Sync |
There was a problem hiding this comment.
Suggested change
| Sync | |
| SyncDrive |
I think the above makes more sense.
yaira2
added
changes requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes