Feat/google3 typings support #9085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranc-google
requested review from
a team,
erikeldridge and
hsubox76
as code owners
🦋 Changeset detectedLatest commit: 30e4182 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dlarocque
reviewed
Jun 10, 2025
eranc-google
force-pushed
the
feat/google3-typings-support
branch
from
962e48e to
83e72ac
Compare
dlarocque
reviewed
Jun 11, 2025
Co-authored-by: Daniel La Rocque <dlarocque.contact@gmail.com>
hsubox76
reviewed
Jun 16, 2025
eranc-google
force-pushed
the
feat/google3-typings-support
branch
from
680e40a to
615fb99
Compare
hsubox76
approved these changes
Jun 17, 2025
|
One last thing, to fix the formatting check just run |
…nc-google/firebase-js-sdk into feat/google3-typings-support
mansisampat
pushed a commit
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new Rollup build configuration to the analytics and remote-config packages. This is required to generate self-contained TypeScript definition (.d.ts) files, which are necessary for consuming these modular SDKs within google3.
This change follows the process outlined in the internal guide for this migration: go/how-to-migrate-to-modular-firebase-js-sdk.
Discussion
There is no public GitHub issue for this change. This work is part of an internal migration effort for Google's Chronicle SOAR UI (internal design doc: go/soar-custom-signals).
This was discussed internally with members of the Firebase team (Christina Holland), who pointed us to the migration guide that necessitates this PR.
Testing
These changes are additive and only affect the build configuration; they do not modify any of the core library source code in /src. As such, they should not impact existing tests.
The project builds successfully (yarn build) with these changes included. The ultimate test for this change will be its consumption by the internal google3 build process after the generated artifacts are imported.
API Changes
This PR introduces no changes to the public API. All modifications are confined to devDependencies in package.json and the addition of a new, non-default build step in rollup.config.js.