Skip to content

chore!: update engines.node to minimum of 20 #9128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Jun 26, 2025

Node 18 is now no longer maintained by Node and is deprecated by Google Cloud as well https://cloud.google.com/functions/docs/runtime-support#node.js

Node 20 is in "maintenance" and should be a safe minimum requirement. https://nodejs.org/en/about/previous-releases

Copy link

changeset-bot bot commented Jun 26, 2025

🦋 Changeset detected

Latest commit: beed9cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@firebase/rules-unit-testing Major
@firebase/app-check-compat Minor
@firebase/firestore-compat Minor
@firebase/functions-compat Minor
@firebase/database-compat Minor
@firebase/storage-compat Minor
@firebase/auth-compat Minor
@firebase/app-compat Minor
@firebase/app-check Minor
@firebase/component Minor
@firebase/firestore Minor
@firebase/functions Minor
@firebase/database Minor
@firebase/storage Minor
@firebase/logger Minor
@firebase/auth Minor
@firebase/util Minor
@firebase/app Minor
@firebase/ai Minor
firebase Major
@firebase/analytics-compat Patch
@firebase/installations-compat Patch
@firebase/messaging-compat Patch
@firebase/performance-compat Patch
@firebase/remote-config-compat Patch
@firebase/analytics Patch
@firebase/data-connect Patch
@firebase/installations Patch
@firebase/messaging Patch
@firebase/performance Patch
@firebase/remote-config Patch
@firebase/database-types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 26, 2025

Size Report 1

Affected Products

  • @firebase/ai

    TypeBase (3d44792)Merge (2bb91d5)Diff
    browser42.5 kB42.2 kB-316 B (-0.7%)
    main43.7 kB43.3 kB-401 B (-0.9%)
    module42.5 kB42.2 kB-316 B (-0.7%)
  • @firebase/firestore

    TypeBase (3d44792)Merge (2bb91d5)Diff
    browser395 kB395 kB-356 B (-0.1%)
    main616 kB615 kB-555 B (-0.1%)
    module395 kB395 kB-356 B (-0.1%)
    react-native395 kB395 kB-357 B (-0.1%)
  • @firebase/firestore-lite

    TypeBase (3d44792)Merge (2bb91d5)Diff
    browser117 kB116 kB-347 B (-0.3%)
    main160 kB159 kB-608 B (-0.4%)
    module117 kB116 kB-347 B (-0.3%)
    react-native117 kB116 kB-349 B (-0.3%)
  • bundle

    15 size changes

    TypeBase (3d44792)Merge (2bb91d5)Diff
    firestore (CSI Auto Indexing Disable and Delete)291 kB290 kB-238 B (-0.1%)
    firestore (CSI Auto Indexing Enable)291 kB290 kB-238 B (-0.1%)
    firestore (Persistence)322 kB322 kB-201 B (-0.1%)
    firestore (Query Cursors)260 kB260 kB-201 B (-0.1%)
    firestore (Query)258 kB258 kB-201 B (-0.1%)
    firestore (Read data once)248 kB247 kB-201 B (-0.1%)
    firestore (Read Write w Persistence)342 kB342 kB-201 B (-0.1%)
    firestore (Realtime updates)248 kB248 kB-201 B (-0.1%)
    firestore (Transaction)227 kB227 kB-238 B (-0.1%)
    firestore (Write data)228 kB228 kB-238 B (-0.1%)
    firestore-lite (Query Cursors)111 kB111 kB-212 B (-0.2%)
    firestore-lite (Query)107 kB107 kB-212 B (-0.2%)
    firestore-lite (Read data once)82.9 kB82.7 kB-212 B (-0.3%)
    firestore-lite (Transaction)108 kB108 kB-212 B (-0.2%)
    firestore-lite (Write data)92.4 kB92.1 kB-212 B (-0.2%)

  • firebase

    TypeBase (3d44792)Merge (2bb91d5)Diff
    firebase-ai.js33.8 kB33.5 kB-254 B (-0.8%)
    firebase-compat.js807 kB807 kB-174 B (-0.0%)
    firebase-firestore-compat.js351 kB351 kB-174 B (-0.0%)
    firebase-firestore-lite.js140 kB139 kB-351 B (-0.3%)
    firebase-firestore.js459 kB458 kB-366 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cw7DcVISft.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 26, 2025

Size Analysis Report 1

This report is too large (867,627 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/M9lpA6H3sh.html

@hsubox76 hsubox76 changed the title chore: update engines.node to minimum of 22 chore: update engines.node to minimum of 20 Jun 30, 2025
@hsubox76 hsubox76 added this to the v12 milestone Jul 8, 2025
@hsubox76 hsubox76 marked this pull request as ready for review July 8, 2025 18:16
@dlarocque
Copy link
Contributor

Can you add a changeset and indicate that this is a breaking change in the title (!)

@hsubox76 hsubox76 changed the title chore: update engines.node to minimum of 20 chore!: update engines.node to minimum of 20 Jul 9, 2025
@hsubox76 hsubox76 requested a review from a team as a code owner July 9, 2025 22:25
@hsubox76
Copy link
Contributor Author

hsubox76 commented Jul 9, 2025

Can you add a changeset and indicate that this is a breaking change in the title (!)

Added, "chore!" looks really weird, maybe that's not the right category. Doesn't affect the build though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants