[naga] Gracefully handle span lookup with no module source #7390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7165
Description
Gracefully handle looking up the source location for a span when no module source is available. This fixes a possible (although unlikely under normal usage) panic.
Testing
The original repro was via the
wgpu
crate, but rather than add a test at that level, I've added a test inwgsl_errors
that seems like a reasonable approximation of the original.I've also added a test for the
InvalidReturnType
error, because I didn't see an existing one, and fixed a stale comment.Squash or Rebase? Squash, if applicable.
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests. Ranwgsl_errors
locally, will let CI do the rest.CHANGELOG.md
entry. Technically user-facing, but doesn't seem worth a changelog entry.