Skip to content

Fix typos in "Private keys" and "Use a webhook secret" sections #38523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025

Conversation

iamdulanga
Copy link
Contributor

Corrected grammatical issues:

  • Added missing verb "is" in "However, this is not as strong..."
  • Fixed subject-verb agreement in "signature... matches the secret"

These changes improve clarity and maintain the professional quality of the documentation.

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Corrected grammatical issues:

- Added missing verb "is" in "However, this is not as strong..."
- Fixed subject-verb agreement in "signature... matches the secret"

These changes improve clarity and maintain the professional quality of the documentation.
@Copilot Copilot AI review requested due to automatic review settings May 24, 2025 17:38
Copy link

welcome bot commented May 24, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 24, 2025
Copy link
Contributor

github-actions bot commented May 24, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on a staging server. Changes to the data directory are not included in this table.

Source Review Production What Changed
apps/creating-github-apps/about-creating-github-apps/best-practices-for-creating-a-github-app.md fpt
ghec
ghes@ 3.17 3.16 3.15 3.14 3.13
fpt
ghec
ghes@ 3.17 3.16 3.15 3.14 3.13

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR corrects minor grammatical errors in the “Private keys” and “Use a webhook secret” sections of the GitHub Apps best practices doc.

  • Added the missing verb “is” to improve clarity in the environment‐variable recommendation.
  • Fixed subject–verb agreement by changing “match” to “matches” for webhook secret verification.

@Sharra-writes Sharra-writes added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels May 26, 2025
@Sharra-writes
Copy link
Contributor

Nice! Thanks for fixing these. I'll get this added to the merge queue once checks are passing. 💛

@Sharra-writes Sharra-writes added this pull request to the merge queue May 26, 2025
Merged via the queue into github:main with commit 6f1d4a5 May 26, 2025
42 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants