Skip to content

Commit 21875b5

Browse files
committed
Don't split and glob the interpreter name
In the release building script, this changes $1 to "$1", because $1 without quotes means to perform word splitting and globbing (pathname expansion) on the parameter (unless otherwise disabled by the value of $IFS or "set -f", respectively) and use the result of doing so, which isn't the intent of the code. This function is only used from within the script, where it is not given values that would be changed by these additional expansions. So this is mainly about communicating intent. (If in the future it is intended that multiple arguments be usable, then they should be passed as separate arguments to release_with, which should be modified by replacing "$1" with "$@". I have not used "$@" at this time because it is not intuitively obvious that the arguments should be to the interpreter, rather than to the build module, so I don't think this should be supported unless or until a need for it determines that.)
1 parent 7dd8add commit 21875b5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

build-release.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
set -eEu
77

88
function release_with() {
9-
$1 -m build --sdist --wheel
9+
"$1" -m build --sdist --wheel
1010
}
1111

1212
if test -n "${VIRTUAL_ENV:-}"; then

0 commit comments

Comments
 (0)