You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i think that git.utils.get_user_id should return the Effective user and not the. currently the function uses getpass.getuser() which relies on environment variables and not getuid/geteuid functions, from the docs
checks the environment variables LOGNAME, USER, LNAME and USERNAME, in order, and returns the value of the first one which is set to a non-empty string. If none are set, the login name from the password database is returned on systems which support the pwd module, otherwise, an exception is raised.
with the following code
Thus there is nothing to fix, and changing it would be a breaking change as well which is another reason not to pursue this further. Thanks for your understanding.
i think that
git.utils.get_user_id
should return the Effective user and not the. currently the function usesgetpass.getuser()
which relies on environment variables and not getuid/geteuid functions, from the docsWhen run as root we get the following output
i think it would be more useful if gitpython returned the user matching the EUID e.g.
pwd.getpwuid(os.geteuid()).pw_name)
The text was updated successfully, but these errors were encountered: