Run everything through 'black' #1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Byron
force-pushed
the
black-fmt
branch
2 times, most recently
from
2574989 to
f501fcb
Compare
EliahKagan
added a commit
to EliahKagan/GitPython
that referenced
this pull request
Mar 10, 2024
The superclass _traverse method call in Tree.traverse appears to have once had a working suppression for the incompatbile types of two arguments, `predicate` and `prune`, as well as for an argument that required (and requires) no suppression, `depth`. These three arguments were written on the same line, which bad a `type: ignore` comment on it. But when black formatting was applied in 21ec529 (gitpython-developers#1442), that comment moved so that it was on a line with just the `depth` call that didn't need it, rather than the others that did. Since then, mypy has reported errors, which further seem intended to suppress based on the surrounding context and the use of `cast` to deal with the static type incompatibilities going the other way. This misplaced suppression was one of the ones I very recently removed in 84fc806. But really there should be a suppression for those arguments (at least for now, while the code remains written that way, given that a suppression is intended). This suppresses the error effectively by inserting two suppression comments, one for each of the two arguments. This is more specific than a single suppression applying to the whole call, and keeping the arguments on separate lines both makes black happy and makes clear that it is not by coincidence that the error is suppressed for both of them. The new suppressions are also written for the specific mypy error at issue, rather than fully general as before. This change decreases the number of mypy errors by two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way people who use it won't be deterred, while it unifies style
everywhere.