Fixes on cmd.py (fd leak and signal exception) #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if command is called with as_proces=True, pipes for the command will not be closed. This change makes sure to close command file descriptors.
When command run as subprocess, AutoInterrupt will kill the process on destructor. However, if process already finished, it raise OSError exception. This fix just ignore OSError on os.kill.
|
Thank you for fixing this - this one is a critical issue ! |
|
Please note that I am merging it into master, which is the latest development stream for the upcoming 0.4 release. This means that 0.3 branches would need a backport. In this case, it would be easy to do though. |
Byron
added a commit
that referenced
this pull request
May 8, 2012
Fixes on cmd.py (fd leak and signal exception) Currently if command is called with as_proces=True, pipes for the command will not be closed. cb68f36 makes sure to close command file descriptors. Ignore signal exception on AutoInterrupt destructor. When command run as subprocess, AutoInterrupt will kill the process on destructor. However, if process already finished, it raise OSError exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I found some problems on cmd.py and tried to write fixes.
Please consider to merge.
Fix fd leak on git cmd.
Currently if command is called with as_proces=True, pipes for the
command will not be closed.
cb68f36 makes sure to close command file descriptors.
Ignore signal exception on AutoInterrupt destructor.
When command run as subprocess, AutoInterrupt will kill the
process on destructor. However, if process already finished,
it raise OSError exception.
f467834 fix just ignore OSError on os.kill.