git: repo: base: update clone_from env argument description #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Byron please take a look, when able. |
Byron
approved these changes
Sep 30, 2019
| @@ -1012,6 +1012,9 @@ def clone_from(cls, url, to_path, progress=None, env=None, multi_options=None, * | |||
| :param to_path: Path to which the repository should be cloned to | |||
| :param progress: See 'git.remote.Remote.push'. | |||
| :param env: Optional dictionary containing the desired environment variables. | |||
| Note: Provided variables will be used to update the execution | |||
| environment for `git`. If some variable is not specified in `env` | |||
There was a problem hiding this comment.
Maybe you could also hint at how to 'unset' environment variables that way.
It's just a suggestion though, I am happy to merge as is.
There was a problem hiding this comment.
Sure, I'll mention that :)
pared
force-pushed
the
update_env_kwarg
branch
from
274661b to
368b4c9
Compare
|
Perfect, thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #924, iterative/dvc#2471