Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for separeted git dir. #99

Merged
merged 1 commit into from
Nov 19, 2014

Conversation

niyaton
Copy link
Contributor

@niyaton niyaton commented Feb 27, 2013

Git-init command supported --separate-git-dir option.
The repository initialized with this option manage the repository by using .git file instead of the .git directory.

I added support for these type repositories.

@jmlundberg
Copy link

I tried this and it work great when doing r=git.Repo().

It seems to not work for submodules: git.Repo().submodules[0].module_exists() still reports false if it uses a .git file. That is the case if git submodule update was first done using modern versions of command line git (at least 1.8.3.1 but likely earlier versions as well).

@Byron Byron added this to the v0.3.3 milestone Nov 19, 2014
@Byron Byron merged commit 53b65e0 into gitpython-developers:0.3 Nov 19, 2014
@Byron
Copy link
Member

Byron commented Nov 19, 2014

Thank you !
I had to make a minor for read_gitfile to actually work, and a test-case is yet to be written as well. Therefore I could only verify that it doesn't fail/break existing functionality.

@jmlundberg The submodule implementation has plenty of issues right now, the one you mention might be related to the 'new' way of storing submodules, which is not yet supported by the submodule implementation. These issues will be handled separately.

@Byron Byron mentioned this pull request Nov 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants