docs: Update user-guides/recover_ingester_pods_in_zone_failure_outages.md
#18309
+16
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ader Fu <ader.ydfu@gmail.com>
ydFu
requested review from
periklis,
xperimental,
JoaoBraveCoding and
a team
as code owners
xperimental
reviewed
Jul 2, 2025
Comment on lines
39
to
40
| - version: v12 | ||
| effectiveDate: "2022-06-01" |
There was a problem hiding this comment.
We usually do not indent lists in our YAML examples:
Suggested change
| - version: v12 | |
| effectiveDate: "2022-06-01" | |
| - version: v12 | |
| effectiveDate: "2022-06-01" |
Comment on lines
48
to
49
| - topologyKey: topology.kubernetes.io/zone | ||
| maxSkew: 1 |
There was a problem hiding this comment.
Suggested change
| - topologyKey: topology.kubernetes.io/zone | |
| maxSkew: 1 | |
| - topologyKey: topology.kubernetes.io/zone | |
| maxSkew: 1 |
There was a problem hiding this comment.
Thanks for the suggestion, I hadn't thought about such details in the yaml format before.
Signed-off-by: Ader Fu <ader.ydfu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The following is the corrected, working YAML configuration that conforms to the Loki Operator’s CRD (Custom Resource Definition) structure
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR