Fixes #4172 Timeout revamp and remove continuous mouse #4173
Conversation
…(old implementation of WantContinuousButtonPressed)
…on firing twice immediately as mouse is pressed down.
tznind
changed the title
tznind
changed the title
There was a problem hiding this comment.
I am so in love with this PR.
Please see my comments. Mostly about naming stuff.
I made some signifcant changes to the mouse event handling in
to address related bugs that may or may not make merging this difficult.
I'm more than happy to try to deal with that. Or, if you are motivated, please merge #4165 into this first. Just let me know your preference.
Thanks.
| public View? MouseGrabView { get; } | ||
|
|
||
| /// <summary>Invoked when a view wants to grab the mouse; can be canceled.</summary> | ||
| public event EventHandler<GrabMouseEventArgs>? GrabbingMouse; |
There was a problem hiding this comment.
I think these events should be "MouseGrabViewChanging" and "MouseGrabViewChanged".
No need for the "Un" versions (if MouseGrabView is null...).
What do you think?
| /// is called. | ||
| /// </summary> | ||
| /// <param name="view">View that will receive all mouse events until <see cref="UngrabMouse"/> is invoked.</param> | ||
| public void GrabMouse (View? view); |
There was a problem hiding this comment.
If this were Set (View? view) we could nuke the UnGrab() method, simplifying the surface area?
| /// Runs all idle hooks | ||
| /// </summary> | ||
| void LockAndRunIdles (); | ||
|
|
||
| /// <summary> | ||
| /// Runs all timeouts that are due | ||
| /// </summary> | ||
| void LockAndRunTimers (); |
There was a problem hiding this comment.
Is "Lock" really needed in the name of this function?
| @@ -44,6 +21,9 @@ public interface ITimedEvents | |||
| /// </remarks> | |||
| object AddTimeout (TimeSpan time, Func<bool> callback); | |||
There was a problem hiding this comment.
"Timeout" in AddTimeout is superfluous, now right? This and RemoveTimeout can be just Add and Remove?
| /// <see langword="false"/> | ||
| /// if the idle handler is not found.</returns> | ||
| bool RemoveIdle (Func<bool> fnTrue); | ||
|
|
||
| /// <summary> | ||
| /// Invoked when a new timeout is added. To be used in the case when | ||
| /// <see cref="Application.EndAfterFirstIteration"/> is <see langword="true"/>. | ||
| /// </summary> | ||
| event EventHandler<TimeoutEventArgs>? TimeoutAdded; |
| /// there are no active timers. | ||
| /// </param> | ||
| /// <returns><see langword="true"/> if there is a timer active.</returns> | ||
| bool CheckTimers (out int waitTimeout); |
| @@ -32,15 +32,15 @@ internal interface IMainLoopDriver | |||
| void Wakeup (); | |||
| } | |||
|
|
|||
| /// <summary>The MainLoop monitors timers and idle handlers.</summary> | |||
| /// <summary>The MainLoop monitors timers handlers.</summary> | |||
| @@ -32,15 +32,15 @@ internal interface IMainLoopDriver | |||
| void Wakeup (); | |||
| } | |||
|
|
|||
| /// <summary>The MainLoop monitors timers and idle handlers.</summary> | |||
| /// <summary>The MainLoop monitors timers handlers.</summary> | |||
| /// <remarks> | |||
There was a problem hiding this comment.
This remarks i no longer needed.
| /// <summary> | ||
| /// <para> | ||
| /// Handler for raising periodic events while the mouse is held down. | ||
| /// Typically, mouse pointer only needs to be pressed down in a view |
I didn't realize it was still failing, because it never failed me again. |
This is super set of #4172 and #4123 it adds also the smooth timeout class
Fixes
v2win/v2net-WantContinuousButtonPresseddoes not repeat. #4101Proposed Changes/Todos
Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)