Skip to content

Commit 75ac785

Browse files
quaffbeikov
authored andcommitted
Polishing JakartaPublishingPlugin
1. fix `Note: Recompile with -Xlint:unchecked for details.` 2. return value of method `addVariant` is not used. 3. refine lambda. 4. remove unused import.
1 parent bad79af commit 75ac785

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

local-build-plugins/src/main/java/org/hibernate/orm/jakarta/JakartaPublishingPlugin.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
import org.gradle.api.model.ObjectFactory;
2525
import org.gradle.api.tasks.TaskContainer;
2626
import org.gradle.api.tasks.TaskProvider;
27-
import org.gradle.api.tasks.testing.Test;
2827

2928
/**
3029
* Models a publishable Jakartafied project
@@ -168,7 +167,7 @@ private void addJavadocVariant(AdhocComponentWithVariants jakartaComponent, Proj
168167
}
169168

170169

171-
private Configuration addVariant(
170+
private void addVariant(
172171
String configName,
173172
String jarTaskName,
174173
String classifier,
@@ -199,17 +198,14 @@ private Configuration addVariant(
199198
mainJarTask = tasks.register(
200199
jarTaskName,
201200
JakartaJarTransformation.class,
202-
203-
(jakartaficationTask) -> {
204-
jakartaficationTask.setDescription( "Produces the Jakartafied main jar for `" + project.getPath() + "`" );
205-
}
201+
(jakartaficationTask) -> jakartaficationTask.setDescription( "Produces the Jakartafied main jar for `" + project.getPath() + "`" )
206202
);
207203
if ( tasks.getNames().contains( "assemble" ) ) {
208204
tasks.named( "assemble" ).configure( (assembleTask) -> assembleTask.dependsOn( mainJarTask ) );
209205
}
210206
}
211207
else {
212-
mainJarTask = (TaskProvider) tasks.named( jarTaskName );
208+
mainJarTask = tasks.named( jarTaskName, JakartaJarTransformation.class );
213209
}
214210

215211
variantConfig.getOutgoing().artifact(
@@ -220,8 +216,6 @@ private Configuration addVariant(
220216
artifact.builtBy( jakartaJarTask );
221217
}
222218
);
223-
224-
return variantConfig;
225219
}
226220

227221
}

0 commit comments

Comments
 (0)