HHH-19498 - improve upserts on MySQL and Maria #10275
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrenaat
changed the title
jrenaat
force-pushed
the
HHH-19498_mysqlupsertimprovement
branch
2 times, most recently
from
918613e to
4a39789
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...re/src/main/java/org/hibernate/dialect/sql/ast/SqlAstTranslatorWithOnDuplicateKeyUpdate.java
Fixed
Show fixed
Hide fixed
jrenaat
force-pushed
the
HHH-19498_mysqlupsertimprovement
branch
3 times, most recently
from
517ce5f to
8c07fc9
Compare
jrenaat
changed the title
beikov
reviewed
Jun 27, 2025
...re/src/main/java/org/hibernate/dialect/sql/ast/SqlAstTranslatorWithOnDuplicateKeyUpdate.java
Outdated
Show resolved
Hide resolved
|
I think what we need to do here is fall back to the "dumb" approach (with an We can still use this new strategy when there is no version to check. |
jrenaat
force-pushed
the
HHH-19498_mysqlupsertimprovement
branch
from
8c07fc9 to
9ad84bd
Compare
hibernate-core/src/main/java/org/hibernate/dialect/MySQLDeleteOrUpsertOperation.java
Fixed
Show fixed
Hide fixed
jrenaat
force-pushed
the
HHH-19498_mysqlupsertimprovement
branch
2 times, most recently
from
d67391f to
9430048
Compare
hibernate-core/src/main/java/org/hibernate/dialect/sql/ast/MySQLSqlAstTranslator.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Jan Schatteman <jschatte@redhat.com>
jrenaat
force-pushed
the
HHH-19498_mysqlupsertimprovement
branch
from
9430048 to
fcb6cef
Compare
Done, let me know what you think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19498