Skip to content

Add Korean translation for glossary.md #38804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

JoosunH
Copy link

@JoosunH JoosunH commented Jun 13, 2025

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@JoosunH
Copy link
Author

JoosunH commented Jun 13, 2025

Hi @jungnerd , I've finished translating glossary.md into Korean.
Following the i18n guidelines — would appreciate your review when you have time 😊
Thank you!

@Rocketknight1
Copy link
Member

cc @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this! We can merge once @jungnerd approves 🙂

Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요! 좋은 번역 정말 감사합니다 🤗
리뷰를 하며 문서를 읽어보니 굉장히 유익하네요!

현재 C 파트까지 리뷰 완료했고, 곧 이어서 리뷰하겠습니다.

I’ve reviewed up to the C section, and I will continue the rest of the docs shortly.

JoosunH and others added 5 commits June 16, 2025 15:44
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나머지 부분도 리뷰해보았습니다!
헤딩 중 번역이 안된 부분에는 번역을 추가하였고, 일부 단어에 대해서는 다른 번역을 제안드렸습니다. 😊
좋은 번역 정말 감사합니다!

Copy link
Contributor

@jungnerd jungnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

나머지 부분도 리뷰해보았습니다!
헤딩 중 번역이 안된 부분에는 번역을 추가하였고, 일부 단어에 대해서는 다른 번역을 제안드렸습니다. 😊
좋은 번역 정말 감사합니다!

JoosunH and others added 7 commits June 24, 2025 10:01
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
Co-authored-by: Woojun Jung <46880056+jungnerd@users.noreply.github.com>
@JoosunH
Copy link
Author

JoosunH commented Jun 24, 2025

감사합니다! 모든 제안사항 반영하였습니다! 확인 부탁드립니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants