Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate tests with features they test #3864

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

WhyNotHugo
Copy link
Contributor

Running cargo test fails to compile because tests rely on types which are behind a #[cfg(…)] which is disabled by default.

Add a #[cfg(…)] directive to tests which rely on types which are also behind a #[cfg(…)] directive, so that these tests run only if the types on which they depend exist.

Running `cargo test` fails to compile because tests rely on types which
are behind a #[cfg(…)] which is disabled by default.

Add a #[cfg(…)] directive to tests which rely on types which are also
behind a #[cfg(…)] directive, so that these tests run only if the types
on which they depend exist.
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up!

@seanmonstar seanmonstar merged commit c449528 into hyperium:master Mar 24, 2025
22 checks passed
@WhyNotHugo WhyNotHugo deleted the test-features branch March 24, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants