Skip to content

add bidirectional streaming support for external snapshot streaming #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

shivaji-kharse
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings June 25, 2025 12:26
@shivaji-kharse shivaji-kharse requested a review from a team as a code owner June 25, 2025 12:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces bidirectional streaming for external snapshot functionality. Key changes include replacing unary response methods with stream-based ones in generated gRPC code, adding a new "finish" field to the snapshot response message, and updating the proto service definition to use bidirectional streaming.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
protos/api.v2/api.v2_grpc.pb.go Replaces CloseAndRecv/SendAndClose with Recv/Send for bidirectional streaming and updates ServiceDesc accordingly.
protos/api.v2/api.v2.pb.go Adds a new "Finish" boolean field and its getter to the snapshot response message.
protos/api.v2.proto Updates the RPC definition to switch from a unary to bidirectional streaming response.
Comments suppressed due to low confidence (3)

protos/api.v2/api.v2_grpc.pb.go:181

  • Replacing CloseAndRecv with Recv may require clients to explicitly call CloseSend() to terminate the send stream. Ensure that this change is clearly communicated in the documentation to prevent resource leaks.
	Recv() (*StreamExtSnapshotResponse, error)

protos/api.v2/api.v2.pb.go:1515

  • [nitpick] Consider adding documentation or code comments to clarify the intended semantics of the new 'Finish' field to facilitate its usage on the client side.
	Finish        bool                   `protobuf:"varint,1,opt,name=finish,proto3" json:"finish,omitempty"`

protos/api.v2.proto:34

  • Changing the RPC signature to bidirectional streaming is a breaking change; ensure that clients are updated accordingly and that compatibility guidelines are documented.
  rpc StreamExtSnapshot(stream StreamExtSnapshotRequest) returns (stream StreamExtSnapshotResponse) {}

@mangalaman93 mangalaman93 merged commit 3290110 into main Jul 9, 2025
6 checks passed
@mangalaman93 mangalaman93 deleted the shiva/bi-stream branch July 9, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants