Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: tighten rules-unit-testing patch, matches upstream PR attempt #8421

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

mikehardy
Copy link
Collaborator

Description

Doing some dependency upgrades and I always look to trim the count of patches we carry, attempting to upstream this one now and the PR I proposed (after testing it...) is more minimal than our current in-tree patch, synching it here

works in testing, is minimal compared to previous

Related issues

See:

Release Summary

Test-only code, no release

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

Most of the database e2e tests uses the database/e2e/helpers.js::seed function, which uses this rules-unit-testing feature requiring the patch, if database e2e passes this works - and it passes for me locally


Think react-native-firebase is great? Please consider supporting the project with any of the below:

Copy link

vercel bot commented Mar 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 2:54pm

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Mar 24, 2025
@mikehardy mikehardy enabled auto-merge (rebase) March 27, 2025 13:18
@mikehardy mikehardy disabled auto-merge March 27, 2025 13:18
@mikehardy mikehardy merged commit 15e108e into main Mar 27, 2025
19 checks passed
@mikehardy mikehardy deleted the @mikehardy/upstream-rules-unit-testing-patch branch March 27, 2025 13:18
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant