Skip to content

feat(datetime): fix height when presentation='time' #30416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 21, 2025
Merged

Conversation

OS-giulianasilva
Copy link
Contributor

@OS-giulianasilva OS-giulianasilva commented May 19, 2025

Issue number: resolves #internal


What is the current behavior?

The datetime component had a broken display for the ionic theme, because the height defined for that component was too small.
image

What is the new behavior?

The CSS code limiting the height was removed. Now, the height is set automatically.
image

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 8:59am

@github-actions github-actions bot added the package: core @ionic/core package label May 19, 2025
@OS-giulianasilva OS-giulianasilva marked this pull request as ready for review May 20, 2025 17:12
@OS-giulianasilva OS-giulianasilva requested a review from a team as a code owner May 20, 2025 17:12
@OS-giulianasilva OS-giulianasilva requested review from gnbm and ShaneK May 20, 2025 17:12
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid fix! Looks good to me 🚀

@OS-giulianasilva OS-giulianasilva merged commit 1877ac5 into next May 21, 2025
48 checks passed
@OS-giulianasilva OS-giulianasilva deleted the ROU-11932 branch May 21, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants