fix(progress-bar, spinner): update colors for ionic theme #30418
Conversation
- Change Spinner Medium Color Variation;
JoaoFerreira-FrontEnd
added
package: core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- improve way to get color var
| @@ -11,6 +11,10 @@ | |||
| height: globals.$ion-scale-700; | |||
| } | |||
|
|
|||
| :host(.ion-color-medium) { | |||
| color: #{globals.ion-color(medium, contrast, $subtle: true)}; | |||
There was a problem hiding this comment.
So I'm still against this because really we shouldn't be changing the behavior of a color like this. Ideally, colors would be consistently applied, saying I want color medium here should be color medium, not the subtle color you're going for. I think you're trying to get the default color that's applied when no color is applied - the value set in the host - which is why you're doing this here, but I don't think this is the right thing to do since the user is saying they want the medium color and you're actively not giving them a medium color but the subtle form of the contrast of the medium color.
I think what you should do is handle this in the widget, just check if the medium color was passed and don't set the color value if it was if that's what you're going for, because I think this will create unexpected results in the long term.
However, I will approve it still because it's more-or-less a nit at this point and I think we're going to have to review colors at some point in the future where this will end up being changed anyway. So either way you want to go I'll approve, I just don't think this is the right way, personally.
There was a problem hiding this comment.
I understand your point/concern. I'll share it with the Design team and PO
|
I updated the PR title to be a fix since the PR is aiming to change the outcome to reflect the true styles. |
thetaPC
changed the title
Issue number: internal
What is the current behavior?
The colors were not working on progress bar when the theme was ionic;
The Spinner with color="medium" should use the contrast variation by design;
What is the new behavior?
Does this introduce a breaking change?
Other information
https://ionic-framework-git-rou-11917-ionic1.vercel.app/src/components/progress-bar/test/basic?ionic:theme=ionic
https://ionic-framework-git-rou-11917-ionic1.vercel.app/src/components/spinner/test/color?ionic:theme=ionic