Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix strips emoji fixing UI #4247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

X1Vi
Copy link

@X1Vi X1Vi commented Feb 9, 2025

  • PR Description
    Now the emoji is not visible in the commits panel. However a commit message is not changed it remains as is. This fixes the UI issue where it was distrubing the diff panel

Closes #3811

  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • [] If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • [] Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Now the emoji is not visible in the commits panel. However a commit
message is not changed it remains as is. This fixes the UI issue where
it was distrubing the diff panel

Closes jesseduffield#3811

fixed linting issues
@stefanhaller
Copy link
Collaborator

I don't think this is an appropriate fix; I do want to see emojis in the commits panel. We should rather fix the printing of the emojis so that it doesn't have these alignment issues. Now this may be tricky, depending on the terminal emulator being used, but I do think we should try to support Mode 2027 (see here) and then hope that more terminal emulators catch up to support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emojis in Commit Messages can Break UI Layout and Affect Displayed Diffs
2 participants