Include FPT In Subtotal not working as configured

[roman204]

Preconditions and environment

• Magento version 2.4.7-p4
• Module MagentoWeee enabled
• Attribute exists for FPT and attribute is assigned to products

Steps to reproduce

1. Add product
2. Add FTP value to product
3. Navigate to Frontend
4. Add product with configured FPT to cart
5. Configure FPT not to be included in subtotal (tax/wee/include_in_subtotal) to value "No"
6. Navigate to cart and check subtotal, the FTP is always included in subtotal

Expected result

subtotal is without the FPT and gets listes in totals below subtotal

Actual result

subtotal is always including FPT and is listed below subtotal

Additional information

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @roman204. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @roman204,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in latest 2.4-develop instance and we are not able to reproduce the issue.kindly refer the screenshots.

subtotal is without the FPT and gets listes in totals below subtotal

Could you please try to reproduce the issue in latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

[roman204]

@magento give me a 2.4-develop instance

[roman204]

seems like i dont get an instance.. i investigated and played around with the options and found out that two lines are responsible for this behaviour see the patch here:

Index: vendor/magento/module-weee/Model/Total/Quote/WeeeTax.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/vendor/magento/module-weee/Model/Total/Quote/WeeeTax.php b/vendor/magento/module-weee/Model/Total/Quote/WeeeTax.php
--- a/vendor/magento/module-weee/Model/Total/Quote/WeeeTax.php	
+++ b/vendor/magento/module-weee/Model/Total/Quote/WeeeTax.php	(date 1741336482517)
@@ -224,13 +224,14 @@
         if ($this->weeeData->includeInSubtotal($this->_store)) {
             $total->addTotalAmount('subtotal', $rowValueExclTax);
             $total->addBaseTotalAmount('subtotal', $baseRowValueExclTax);
+            $total->setSubtotalInclTax($total->getSubtotalInclTax() + $rowValueInclTax);
+            $total->setBaseSubtotalInclTax($total->getBaseSubtotalInclTax() + $baseRowValueInclTax);
         } else {
             $total->addTotalAmount('weee', $rowValueExclTax);
             $total->addBaseTotalAmount('weee', $baseRowValueExclTax);
         }
 
-        $total->setSubtotalInclTax($total->getSubtotalInclTax() + $rowValueInclTax);
-        $total->setBaseSubtotalInclTax($total->getBaseSubtotalInclTax() + $baseRowValueInclTax);
+
         $address->setBaseSubtotalTotalInclTax($total->getBaseSubtotalInclTax());
         $address->setSubtotalInclTax($total->getSubtotalInclTax());
         return $this;

[engcom-Bravo]

Hi @roman204,

Thanks for your update.

As per this comment #39715 (comment) the issue is no more reproducible in latest 2.4-develop instance can we close this issue please update us.

Thanks.

[engcom-Bravo]

Hi @roman204,

This issue is being closed since it has not been updated in a long time.Please feel free to reopen or raise a new ticket if the issue still exists.

Thanks.