Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registered shipping rates validators are not running #39039

Closed
kooliahmd opened this issue Aug 13, 2024 · 4 comments · May be fixed by #39759
Closed

Registered shipping rates validators are not running #39039

kooliahmd opened this issue Aug 13, 2024 · 4 comments · May be fixed by #39759
Assignees
@engcom-Hotel
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@kooliahmd
Copy link

kooliahmd commented Aug 13, 2024 •
edited
Loading

Summary

Following this documentation in order to register a custom shipping rate validator, I found out that shipping-rates-validator.js::validateAddressData would never execute the registered validator as long as the default validator returns true.

This is because shipping-rates-validator.js registers a default-validator and when it runs the validation it considers the rates as valid when at least on of the registered validators returned true.
This is problematic, as the custom validator would not even run when the default validator returns true.

Examples

N/A

Proposed solution

Change this function validateAddressData in module-checkout/view/frontend/web/js/model/shipping-rates-validator.js

From:

        validateAddressData: function (address) {
            return validators.some(function (validator) {
                return validator.validate(address);
            });
        },

To:

        validateAddressData: function (address) {
            return validators.forEach(function (validator) {
                return validator.validate(address);
            });
        },
    ```    

### Release note

_No response_

### Triage and priority

- [ ] Severity: **S0** _- Affects critical data or functionality and leaves users without workaround._
- [ ] Severity: **S1** _- Affects critical data or functionality and forces users to employ a workaround._
- [X] Severity: **S2** _- Affects non-critical data or functionality and forces users to employ a workaround._
- [ ] Severity: **S3** _- Affects non-critical data or functionality and does not force users to employ a workaround._
- [ ] Severity: **S4** _- Affects aesthetics, professional look and feel, “quality” or “usability”._
@kooliahmd kooliahmd added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Aug 13, 2024
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Aug 13, 2024

Hi @kooliahmd. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Aug 14, 2024
@engcom-Hotel engcom-Hotel moved this to Ready for Confirmation in Issue Confirmation and Triage Board Aug 19, 2024
@engcom-Hotel engcom-Hotel self-assigned this Aug 26, 2024
@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Aug 26, 2024

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sorry, something went wrong.

@engcom-Hotel engcom-Hotel added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels Aug 26, 2024
@engcom-Hotel engcom-Hotel moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Aug 26, 2024
@engcom-Hotel
Copy link
Contributor

Hello @kooliahmd,

Thanks for the report and collaboration!

We have tried to reproduce the issue in the latest 2.4-develop branch. In order to reproduce it we have made a custom module as follows:

https://github.com/engcom-Hotel/magento2/tree/issue39039/app/code/Magz/Issue39039

But we are unable to reproduce it, can you please let us know if we missed anything?

Thanks

@engcom-Hotel
Copy link
Contributor

Dear @kooliahmd,

We've observed that there haven't been any updates on this issue for quite some time. Therefore, we assume it's been resolved and will close it. Feel free to open a new ticket or reopen this one if you require further assistance.

Regards

This was referenced Mar 25, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engcom-Hotel engcom-Hotel

Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.x Indicates original Magento version for the Issue report. Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
None yet
Milestone
No milestone
3 participants
@kooliahmd @engcom-Bravo @engcom-Hotel