Skip to content

Conversation

thebentern
Copy link
Contributor

I believe we should ignore Users which have a mismatch of mac address and nodenum.

@thebentern thebentern requested review from jp-bennett and GUVWAF May 30, 2025 11:43
@GUVWAF
Copy link
Member

GUVWAF commented May 30, 2025

One caveat here is when a node generates a random NodeNum when it detects a duplicate one on the mesh.

@thebentern
Copy link
Contributor Author

One caveat here is when a node generates a random NodeNum when it detects a duplicate one on the mesh.

I had this thought as well. What do you think is a good mitigation strategy? I'm not sure there's a great experience to be had for duplicates on the mesh

@GUVWAF
Copy link
Member

GUVWAF commented May 30, 2025

Maybe a client notification (only once upon new discovery)? Then you can always ignore/delete the node yourself.

At this point I'm fairly certain there are nodes around where this has happened, especially since RAK sent out batches of nodes with the same NodeNum.

@jp-bennett
Copy link
Collaborator

I booted my laptop and ran meshtasticd just today, and it generated a new random nodenum, complaining that another device had its mac. As much as I would like to be able to do this, I think the blast radius would be too high.

@caveman99 caveman99 force-pushed the dont-process-mac-mismatch branch from abd0a5d to 960d984 Compare July 14, 2025 14:10
@caveman99 caveman99 added the bugfix Pull request that fixes bugs label Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants