Add customizable boot logo based on resolution #7146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
vidplace7
force-pushed
the
load_branding
branch
2 times, most recently
from
ee56cf8 to
abb8b88
Compare
vidplace7
commented
Jun 27, 2025
vidplace7
force-pushed
the
load_branding
branch
3 times, most recently
from
aac9457 to
2819251
Compare
vidplace7
force-pushed
the
load_branding
branch
2 times, most recently
from
349cfab to
cb4eede
Compare
mverch67
requested changes
Jul 1, 2025
There was a problem hiding this comment.
As discussed I think we definitely should not use the SCREEN_ROTATE macro for this. Besides that it's now really ugly to have it moved from variant.h into platformio.ini (which nobody will understand why and which is kinda error prone) this macro is not used by MUI but now should be used together with two other macros to determine the boot logo size.... eek.
I'd rather suggest to use an either explicit (e.g. USE_BOOTLOGO=logo_320x480.png) or implicit (e.g. DISPLAY_SIZE=320x480) macro that helps to handle the size and orientation of the boot logo.
vidplace7
force-pushed
the
load_branding
branch
5 times, most recently
from
ea6efab to
bff9013
Compare
mverch67
reviewed
Jul 1, 2025
mverch67
reviewed
Jul 1, 2025
mverch67
reviewed
Jul 1, 2025
vidplace7
force-pushed
the
load_branding
branch
2 times, most recently
from
ff3bb9f to
5ef04ef
Compare
vidplace7
force-pushed
the
load_branding
branch
2 times, most recently
from
eda2138 to
34f3a4f
Compare
mverch67
requested changes
Jul 2, 2025
mverch67
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds customizable boot logos based upon device screen resolution.
Builds upon:
This platformio script callback determines the display resolution, locates the corresponding
branding/logo_<width>x<height>.pngand loads it ontodata/boot/logo.png.See the
logo_xxx.pngfiles inevent/defcon33branding for our first example.DefCon here we come ☠️