Skip to content

fix TRAIN_SCRIPT_PATH value in .env.example #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Conversation

satonaoki
Copy link
Contributor

TRAIN_SCRIPT_PATH value updated from 'training/train.py' to 'training/train_aml.py'.

This is aligned with /.pipelines/diabetes_regression-variables-template.yml.

TRAIN_SCRIPT_PATH value updated from 'training/train.py' to 'training/train_aml.py'.

This is aligned with /.pipelines/diabetes_regression-variables-template.yml.
@j-so
Copy link
Contributor

j-so commented Feb 12, 2021

@satonaoki What is the reason for making this change? We provide both training scripts as examples, and users are welcome to try either. train.py is the simplest and can be run locally, so it been set as the default.

@satonaoki
Copy link
Contributor Author

@j-so

(1) When running the training script locally without Azure ML pipeline, you can simply run train.py directly.

'TRAIN_SCRIPT_PATH' environment variable is not used in this scenario.

(2) When running diabetes_regression_build_train_pipeline.py locally to publish a new Azure ML pipeline as described here, 'TRAIN_SCRIPT_PATH' environment variable in .env is used.

So I think this should be train_aml.py, not train.py. train.py does not work with diabetes_regression_build_train_pipeline.py.

(3) When running diabetes_regression_build_train_pipeline.py from Azure DevOps pipeline, 'TRAIN_SCRIPT_PATH' environment variable in diabetes_regression-variables-template.yml is used. It is already set as 'train_aml.py'.

@j-so
Copy link
Contributor

j-so commented Feb 16, 2021

I see - looks like train.py is now out of date since it was introduced. I agree then that we should switch to train_aml for the local example environment variables.

@j-so j-so merged commit 771c8ef into microsoft:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants