Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define __STDC_FORMAT_MACROS when it hasn't been defined to avoid duplicate define error. #1520

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

sighingnow
Copy link
Contributor

No description provided.

…icate define error.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
@sighingnow
Copy link
Contributor Author

The macro __STDC_FORMAT_MACROS may comes from command line args, or outer CMakeLists.txt when cpprestsdk is used as a submodule.

@sighingnow
Copy link
Contributor Author

Polite ping /cc @BillyONeal @garethsb-sony

@BillyONeal
Copy link
Member

@barcharcraz is the new @BillyONeal to this repo

@sighingnow
Copy link
Contributor Author

Thank you Billy.

Then /cc @barcharcraz 😆

@barcharcraz
Copy link
Member

lg2m

@barcharcraz barcharcraz merged commit e05fede into microsoft:master Nov 3, 2020
@sighingnow sighingnow deleted the ht/std_format_macro branch November 4, 2020 02:19
sighingnow added a commit to v6d-io/v6d that referenced this pull request Nov 4, 2020
See also: microsoft/cpprestsdk#1520.

Signed-off-by: Tao He <linzhu.ht@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants