Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix likely typo in SafeInt3.hpp, that results in error with clang 15 #1711

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

Fighter19
Copy link
Contributor

Please double check before merge.
Prior to this, it resulted in following error while trying to build with the Emscripten toolchain.

[  1%] Building CXX object Release/src/CMakeFiles/cpprest.dir/http/client/http_client.cpp.o
In file included from /cpprestsdk/Release/src/http/client/http_client.cpp:16:
In file included from /cpprestsdk/Release/src/pch/stdafx.h:73:
In file included from /cpprestsdk/Release/include/cpprest/details/basic_types.h:31:
/cpprestsdk/Release/include/cpprest/details/SafeInt3.hpp:1577:32: error: parameter 'b' set but not used [-Werror,-Wunused-but-set-parameter]
    static void CastThrow(bool b, T& t) SAFEINT_CPP_THROW

@blazorin
Copy link

Thanks. This should be merged asap.

@yuxiang-wen
Copy link

yuxiang-wen commented Sep 17, 2022 via email

Copy link
Member

@barcharcraz barcharcraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an oversight

@barcharcraz barcharcraz merged commit e1b6a8e into microsoft:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants