PYTHON-5233 Allow python version to be set at the task level #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
requested changes
Mar 26, 2025
| # Function that gets a python binary given a python version string. | ||
| # Versions can be of the form 3.xx or pypy3.xx. | ||
| get_python_binary() { | ||
| version=$1 |
There was a problem hiding this comment.
Should this have a check to verify that the version is in an expected form?
There was a problem hiding this comment.
NoahStapp
requested changes
Mar 27, 2025
| expansions: | ||
| PYTHON_BINARY: /opt/python/3.11/bin/python3 | ||
| - name: auth-enterprise-rhel8-python3.12 | ||
| - name: auth-enterprise-win64 |
There was a problem hiding this comment.
Are we running less variants for enterprise auth, or are these changes captured elsewhere?
There was a problem hiding this comment.
The same number of total tasks, just run in 3 variants instead of whatever it was before.
NoahStapp
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Win Py3.13 failure is expected: https://spruce.mongodb.com/version/67e2efa85e86b700078bad40/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC