[management, client] Add support for punycode domains in nameservers #3868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>
# Conflicts: # management/server/nameserver.go # management/server/nameserver_test.go
bcmmbaga
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the DNS nameserver handling by replacing plain string representations of domain names with strong‐typed domain.Domain values and adds explicit Punycode conversions to standardize domain formats.
- Replaces string parameters with domain.Domain or domain.List in upstream resolvers, server, and tests
- Updates functions to use Punycode conversions for consistent domain normalization
- Refactors related test cases and handler chain implementations to align with new domain types
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| client/internal/dns/upstream*.go | Updates upstream resolver parameters from string to domain.Domain |
| client/internal/dns/server*.go | Adapts DNS server functions to use domain.Domain and domain.List with appropriate Punycode conversions |
| client/internal/dns/handler_chain*.go | Refactors handler chain pattern matching to use domain.Domain and applies Punycode conversion in comparisons |
| client/internal/dns/host*.go | Converts domain handling within host config functions to domain.Domain with PunycodeString normalization |
| client/iface/* | Changes interface functions to use domain.List for search domains on mobile and non-mobile platforms |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Stack
Checklist