[client] Avoid logging setup keys on error message #3962
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request removes sensitive setup key information from error logs during the peer registration process.
- Removed logging of the setup key when errors occur.
- Update focuses on avoiding leakage of sensitive credentials via log messages.
Comments suppressed due to low confidence (1)
client/internal/login.go:151
- Good change; this update improves security by not logging the sensitive setup key. Verify that no other parts of the system log sensitive credentials inadvertently.
log.Errorf("failed registering peer %v", err)
|
hakansa
approved these changes
Jun 12, 2025
lixmal
approved these changes
Jun 12, 2025
lixmal
reviewed
Jun 12, 2025
Comment on lines
+151
to
152
| log.Errorf("failed registering peer %v", err) | ||
| return nil, err |
There was a problem hiding this comment.
Suggested change
| log.Errorf("failed registering peer %v", err) | |
| return nil, err | |
| return nil, fmt.Errorf("register peer: %w", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
NET-212
Stack
Checklist