-
-
Notifications
You must be signed in to change notification settings - Fork 779
[client] Always register NetBird with plain Linux DNS and use original servers as upstream #3967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the DNS configuration logic to register NetBird as the sole nameserver while passing the original nameservers as low-priority upstream handlers.
- Removes the resolvconf restriction to allow non-all-domain resolvers on Linux
- Adds fallback support to register original nameservers with a lower priority
- Refactors error handling and prioritization logic in the DNS server and file configurator
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
client/internal/dns/server.go | Added fallback registration, refactored error handling, and updated priority overlap handling |
client/internal/dns/resolvconf_unix.go | Added getter for original nameservers and simplified DNS config application |
client/internal/dns/host.go | Removed unused error constant |
client/internal/dns/handler_chain.go | Introduced PriorityFallback constant with a new negative priority value |
client/internal/dns/file_unix.go | Updated backup and restoration process, added retrieval of original nameservers |
client/internal/dns/file_parser_unix.go | Removed options timeout generation logic |
|
Describe your changes
resolvconf
andfile
managersnetip.Addr
resolvconf
as a fallback instead ofopenresolv
RcodeRefused
if no handler was found in the chainIssue ticket number and link
Stack
Checklist