-
-
Notifications
You must be signed in to change notification settings - Fork 777
[Management] replace update channel with buffer #4043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the update channel mechanism by replacing it with a custom update buffer, and it also adds additional network serial number increments in various parts of the codebase. Key changes include:
- Replacing the channel-based update mechanism with an UpdateBuffer.
- Reducing the buffer size constant in updatechannel.go.
- Adding calls to IncrementNetworkSerial in several functions to ensure peers receive updated network information.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
management/server/user.go | Added IncrementNetworkSerial call to update network changes. |
management/server/updatechannel.go | Replaced chan-based channels with UpdateBuffer usage. |
management/server/update_buffer.go | Introduced UpdateBuffer for buffering updates. |
management/server/peer.go | Added IncrementNetworkSerial calls during peer events. |
management/server/grpcserver.go | Updated Sync and handleUpdates to work with the UpdateBuffer. |
management/server/account.go | Added IncrementNetworkSerial call in onPeersInvalidated hook. |
|
Describe your changes
Issue ticket number and link
Stack
Checklist