Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signals): make EntityId type an optional argument in withEntities #4735

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Chiorufarewerin
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #4570

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Copy link

netlify bot commented Mar 22, 2025

Deploy Preview for ngrx-io ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 74871a9
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67df0652bfbccd0008749556
😎 Deploy Preview https://deploy-preview-4735--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC(@ngrx/signals): Add type of id as optional second type arg to withEntities<Entity,Id>()
1 participant