-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sqlite,src: refactor sqlite value conversion #57571
base: main
Are you sure you want to change the base?
sqlite,src: refactor sqlite value conversion #57571
Conversation
Review requested:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57571 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 629 630 +1
Lines 184903 185009 +106
Branches 36223 36221 -2
==========================================
+ Hits 166853 166944 +91
- Misses 11010 11038 +28
+ Partials 7040 7027 -13
🚀 New features to boost your workflow:
|
Is this "returning function body macro" paradigm used elsewhere? Appreciate the rationale, but it seems like it lends potential for future mishaps? |
For this, specifically, I don't think so. This type conversion is unlikely to change. We need to find a way to isolate this anyways since it's being required more and more. |
6cf644e
to
2611aa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor comment.
This PR is a minor refactor on converting SQLite values to JS. It makes the work for #56600 easier and reduces duplication.