Multi Instance: Refactor: Split RootNode And Explorer #2924
Milestone
Comments
alex-courtis
added a commit
that referenced
this issue
Sep 23, 2024
alex-courtis
added a commit
that referenced
this issue
Sep 29, 2024
alex-courtis
added a commit
that referenced
this issue
Sep 30, 2024
alex-courtis
changed the title
alex-courtis
added a commit
that referenced
this issue
Oct 5, 2024
alex-courtis
added a commit
that referenced
this issue
Oct 7, 2024
* refactor(#2875): multi instance renderer * refactor(#2875): multi instance renderer * refactor(#2875): multi instance renderer * refactor(#2875): multi instance renderer * node classes and constructors * node methods * refactor(#2875): multi instance renderer * node classes and constructors * explorer is a directory node * extract methods from explore_node * extract methods from explore_node * extract methods from explore_node * extract methods from lib * use .. name for root node for compatibility * use node.explorer * extract node factory, remove unused code * factories for all nodes, add RootNode * factories for all nodes, add RootNode * use factory pattern for decorators * note regression and commit * fix dir git status regression * destroy nodes, not explorer * add BaseNode:is * revert changes to create-file, handle in #2924 * extract methods from explorer * extract methods from explorer * extract methods from explorer * use Node everywhere in luadoc * extract methods from lib * extract methods from lib * lint * remove unused code * don't call methods on fake root node * get_node_at_cursor returns explorer (root) node instead of { name = '..' } * remove unused inject_node * refactor(#2875): multi instance renderer * refactor(#2875): multi instance renderer * refactor(#2875): multi instance renderer * extract methods from lib * node factory uses stat only * temporary DirectoryNode casting until method extraction into child classes * lua-language-server 3.10.5 -> 3.11.0 * explicitly call Explorer constructor * normalise explorer RootNode new call, tidy annotations
|
This may not be necessary; there are no conflicts with the nodes. RootNode may be unnecessary and Explorer could inherit DirectoryNode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Requires #2916
Explorer is a RootNode. Break them and store RootNode in Explorer.
get_node_at_cursorreturns the root instead of fake".."Replace
name == ".."tests withBaseNode:is(RootNode)Change
nameto be consistent withDirNodeThe text was updated successfully, but these errors were encountered: