Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: $acceptedPredictionTokens must be of type int, null given | #524 😇 #525

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

200-0K
Copy link

@200-0K 200-0K commented Feb 17, 2025

What:

  • Bug Fix
  • New Feature

Description:

Fix $acceptedPredictionTokens must be of type int, null given error for deepseek-reasoner model

Related:

#524

@200-0K 200-0K changed the title Fix: $acceptedPredictionTokens must be of type int, null given | #524 😇 Fix: $acceptedPredictionTokens must be of type int, null given | #524 😇 Feb 17, 2025
@chuoke
Copy link

chuoke commented Feb 24, 2025

I request this change be merged.

@nycomar
Copy link

nycomar commented Mar 20, 2025

I fixed it on my end slightly differently. I only changed line 24 and 25 to "?? 0" instead of "?? null" and then changing the declaration on the top to be nullable.

I think your fix might be better. I too vote that this fix be merged.

+1 vote for me, as openrouter followed suit and also no longer send this attribute back in the response, as of yesterday.

TrojmiastoPl added a commit to TrojmiastoPl/openai-php-client that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants