Replacing any with unknown in the ReadonlyArray type declaration.
#2241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for openapi-ts pending review.Visit the deploys page to approve it
|
🦋 Changeset detectedLatest commit: 2ebb6c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gzm0
requested changes
Apr 3, 2025
There was a problem hiding this comment.
Heya! Thanks a lot for the contribution. Definitely happy to see all these any's go :)
- Just to double check my understanding: This is not a breaking change, correct?
- Please add a changeset so we get a package version bump and an entry in the changelog. (Click here to learn what changesets are, and how to add one.)
|
Thanks, @gzm0 , I have added the changeset. You are right, this should not break anything. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The current declaration of the enhanced
ReadonlyArraytype uses the undesiredanytype instead of the more appropriateunknowntype.docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)