-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8348928: Check for case label validity are misbehaving when binding patterns with unnamed bindings are present #24155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…atterns with unnamed bindings are present
👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into |
@lahodaj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 575 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/integrate |
Going to push as commit 7bfbb9a.
Your commit was automatically rebased without conflicts. |
Consider code like:
This compiles OK, but it shouldn't. The JLS says:
Some similar cases leads to a javac crash:
The root cause here is a bug when determining whether or not a given case label contains bindings - the "has-bindings" flag gets cleared when
_
is used. The "has-bindings" flags must remain set despite seeing unnamed binding variables.Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24155/head:pull/24155
$ git checkout pull/24155
Update a local copy of the PR:
$ git checkout pull/24155
$ git pull https://git.openjdk.org/jdk.git pull/24155/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24155
View PR using the GUI difftool:
$ git pr show -t 24155
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24155.diff
Using Webrev
Link to Webrev Comment