Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352706: httpclient HeadTest does not run on HTTP2 #24191

Closed
wants to merge 1 commit into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Mar 24, 2025

The test was using incorrect URIs for testing, and as a result, the test was never run on HTTP2. Additionally, the HTTP2 test server was using an unconfigured SSLContext, and HTTPS was not usable. Both issues are fixed.

The test continues to pass.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8352706: httpclient HeadTest does not run on HTTP2

Issue

  • JDK-8352706: httpclient HeadTest does not run on HTTP2 (Bug - P4)

Reviewers

Contributors

  • Daniel Fuchs <dfuchs@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24191/head:pull/24191
$ git checkout pull/24191

Update a local copy of the PR:
$ git checkout pull/24191
$ git pull https://git.openjdk.org/jdk.git pull/24191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24191

View PR using the GUI difftool:
$ git pr show -t 24191

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24191.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2025

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@djelinski
Copy link
Member Author

/contributor add @dfuch

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352706: httpclient HeadTest does not run on HTTP2

Co-authored-by: Daniel Fuchs <dfuchs@openjdk.org>
Reviewed-by: michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 5709f79: 8352648: JFR: 'jfr query' should not be available in product builds
  • 02a4ce2: 8352147: G1: TestEagerReclaimHumongousRegionsClearMarkBits test takes very long
  • de58009: 8351468: C2: array fill optimization assigns wrong type to intrinsic call
  • a875733: 8352486: [ubsan] compilationMemoryStatistic.cpp:659:21: runtime error: index 64 out of bounds for type const struct unnamed struct
  • 5591f8a: 8351515: C2 incorrectly removes double negation for double and float
  • 56a4ffa: 8352597: [IR Framework] test bug: TestNotCompilable.java fails on product build

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8352706 8352706: httpclient HeadTest does not run on HTTP2 Mar 24, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 24, 2025
@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@djelinski
Contributor Daniel Fuchs <dfuchs@openjdk.org> successfully added.

@openjdk
Copy link

openjdk bot commented Mar 24, 2025

@djelinski The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Mar 24, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 24, 2025

Webrevs

Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 24, 2025
@djelinski
Copy link
Member Author

Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Mar 26, 2025

Going to push as commit e32a0c9.
Since your change was applied there have been 50 commits pushed to the master branch:

  • 45a9750: 8351655: Optimize ObjectMonitor::unlink_after_acquire()
  • 2e4d7d1: 8302459: Missing late inline cleanup causes compiler/vectorapi/VectorLogicalOpIdentityTest.java IR failure
  • 1a8c8e0: 8352858: Make java.net.JarURLConnection fields final
  • a81250c: 8352673: RISC-V: Vector can't be turned on with -XX:+UseRVV
  • 0935ba9: 8352481: Enforce the use of lld with clang
  • dbc620f: 8352299: GenShen: Young cycles that interrupt old cycles cannot be cancelled
  • f5a0db4: 8315447: Invalid Type Annotation attached to a method instead of a lambda
  • 60544a1: 8164714: Constructor.newInstance creates instance of inner class with null outer class
  • c856b34: 8352587: C2 SuperWord: we must avoid Multiversioning for PeelMainPost loops
  • 993eae4: 8346948: Update CLDR to Version 47.0
  • ... and 40 more: https://git.openjdk.org/jdk/compare/e23e0f85ef0f959a68adda0cff9e721ba2173ffc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 26, 2025
@openjdk openjdk bot closed this Mar 26, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 26, 2025
@openjdk
Copy link

openjdk bot commented Mar 26, 2025

@djelinski Pushed as commit e32a0c9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the http304 branch March 26, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants