-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8352706: httpclient HeadTest does not run on HTTP2 #24191
Conversation
👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into |
/contributor add @dfuch |
@djelinski This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@djelinski |
@djelinski The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review! /integrate |
Going to push as commit e32a0c9.
Your commit was automatically rebased without conflicts. |
@djelinski Pushed as commit e32a0c9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The test was using incorrect URIs for testing, and as a result, the test was never run on HTTP2. Additionally, the HTTP2 test server was using an unconfigured SSLContext, and HTTPS was not usable. Both issues are fixed.
The test continues to pass.
Progress
Warning
8352706: httpclient HeadTest does not run on HTTP2
Issue
Reviewers
Contributors
<dfuchs@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24191/head:pull/24191
$ git checkout pull/24191
Update a local copy of the PR:
$ git checkout pull/24191
$ git pull https://git.openjdk.org/jdk.git pull/24191/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24191
View PR using the GUI difftool:
$ git pr show -t 24191
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24191.diff
Using Webrev
Link to Webrev Comment