8236073: G1: Use SoftMaxHeapSize to guide GC heuristics #24211
+33
−16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I have implemented SoftMaxHeapSize for G1 as attached. It is completely reworked compared to previous PR, and excludes code for
CurrentMaxHeapSize
. I believe I have addressed all direct concerns from previous email thread, such as:MinHeapSize
;MinHeapFreeRatio
,MaxHeapFreeRatio
;This recent thread also has some context.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24211/head:pull/24211
$ git checkout pull/24211
Update a local copy of the PR:
$ git checkout pull/24211
$ git pull https://git.openjdk.org/jdk.git pull/24211/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24211
View PR using the GUI difftool:
$ git pr show -t 24211
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24211.diff
Using Webrev
Link to Webrev Comment