-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106 #24216
Conversation
👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into |
@vpa1977 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 48 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@reinrich, @shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
@@ -24,6 +24,7 @@ | |||
*/ | |||
|
|||
#include "memory/metaspace.hpp" | |||
#include "os_linux.hpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should include os_linux.inline.hpp
(according to the style-guide).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really? I think that rule only says "do not include os_linux.hpp
if os_linux.inline.hpp
is already included". We do not include os_linux.inline.hpp
, so we should include just the os_linux.hpp
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I misread this rule as a rule I expected to exist too (always prefer the *.inline.hpp over *.hpp).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of the issue!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me, thanks!
Looks good to me. |
/integrate |
/sponsor |
Going to push as commit 9a87e21.
Your commit was automatically rebased without conflicts. |
Add missing header to resolve the compilation failure.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24216/head:pull/24216
$ git checkout pull/24216
Update a local copy of the PR:
$ git checkout pull/24216
$ git pull https://git.openjdk.org/jdk.git pull/24216/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24216
View PR using the GUI difftool:
$ git pr show -t 24216
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24216.diff
Using Webrev
Link to Webrev Comment