Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106 #24216

Closed
wants to merge 2 commits into from

Conversation

vpa1977
Copy link
Contributor

@vpa1977 vpa1977 commented Mar 25, 2025

Add missing header to resolve the compilation failure.

Testing:

  • built openjdk in PPC qemu vm.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24216/head:pull/24216
$ git checkout pull/24216

Update a local copy of the PR:
$ git checkout pull/24216
$ git pull https://git.openjdk.org/jdk.git pull/24216/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24216

View PR using the GUI difftool:
$ git pr show -t 24216

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24216.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

👋 Welcome back vpetko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@vpa1977 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106

Reviewed-by: rrich, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

  • 1397ee5: 8334322: Misleading values of keys in jpackage resource bundle
  • 441bd12: 8352812: remove useless class and function parameter in SuspendThread impl
  • e83cccf: 8352948: Remove leftover runtime_x86_32.cpp after 32-bit x86 removal
  • 5672a93: 8348400: GenShen: assert(ShenandoahHeap::heap()->is_full_gc_in_progress() || (used_regions_size() <= _max_capacity)) failed: Cannot use more than capacity #
  • c2a4fed: 8348907: Stress times out when is executed with ZGC
  • 5392674: 8352766: Problemlist hotspot tier1 tests requiring tools that are not included in static JDK
  • 1d205f5: 8352716: (tz) Update Timezone Data to 2025b
  • a2a64da: 8352588: GenShen: Enabling JFR asserts when getting GCId
  • 79bffe2: 8349361: C2: RShiftL should support all applicable transformations that RShiftI does
  • eef6aef: 8352623: MultiExchange should cancel exchange impl if responseFilters throws
  • ... and 38 more: https://git.openjdk.org/jdk/compare/6bc480358c80b0a1a94b5ca5f4b7ff2d84ce8e37...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@reinrich, @shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@vpa1977 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Mar 25, 2025
@vpa1977 vpa1977 marked this pull request as ready for review March 25, 2025 19:00
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2025

Webrevs

@vpa1977 vpa1977 requested a review from shipilev March 25, 2025 22:38
@@ -24,6 +24,7 @@
*/

#include "memory/metaspace.hpp"
#include "os_linux.hpp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should include os_linux.inline.hpp (according to the style-guide).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really? I think that rule only says "do not include os_linux.hpp if os_linux.inline.hpp is already included". We do not include os_linux.inline.hpp, so we should include just the os_linux.hpp.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I misread this rule as a rule I expected to exist too (always prefer the *.inline.hpp over *.hpp).

Copy link
Member

@reinrich reinrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the issue!

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me, thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 26, 2025
@reinrich
Copy link
Member

Looks good to me.
Thanks, Richard.

@vpa1977
Copy link
Contributor Author

vpa1977 commented Mar 26, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 26, 2025
@openjdk
Copy link

openjdk bot commented Mar 26, 2025

@vpa1977
Your change (at version 2a64115) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 27, 2025

Going to push as commit 9a87e21.
Since your change was applied there have been 54 commits pushed to the master branch:

  • 4100dc9: 8350801: Add a code signing hook to the JDK build system
  • 8a40498: 8352678: Opensource few JMenuItem tests
  • 66b5dba: 8350988: Consolidate Identity of self-inverse operations
  • 1007811: 8352897: RISC-V: Change default value for UseConservativeFence
  • 7853415: 8352218: RISC-V: Zvfh requires RVV
  • 2483340: 8352579: Refactor CDS legacy optimization for lambda proxy classes
  • 1397ee5: 8334322: Misleading values of keys in jpackage resource bundle
  • 441bd12: 8352812: remove useless class and function parameter in SuspendThread impl
  • e83cccf: 8352948: Remove leftover runtime_x86_32.cpp after 32-bit x86 removal
  • 5672a93: 8348400: GenShen: assert(ShenandoahHeap::heap()->is_full_gc_in_progress() || (used_regions_size() <= _max_capacity)) failed: Cannot use more than capacity #
  • ... and 44 more: https://git.openjdk.org/jdk/compare/6bc480358c80b0a1a94b5ca5f4b7ff2d84ce8e37...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2025
@openjdk openjdk bot closed this Mar 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 27, 2025
@openjdk
Copy link

openjdk bot commented Mar 27, 2025

@shipilev @vpa1977 Pushed as commit 9a87e21.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants