Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352612: No way to add back lint categories after "none" #24227

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Mar 25, 2025

This PR relates to the -Xlint:none flag. Currently, it not only disables all lint categories as one would expect, but it also disables all non-mandatory warnings, period. In other words, -Xlint:none has -nowarn as a hidden side-effect. So for example, trying to do -Xlint:none,serial to enable only the serial lint category is futile: the category will be enabled but the warnings won't ever appear. This PR removes that hidden side-effect, and also clarifies some of the help output.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8352901 to be approved

Issues

  • JDK-8352612: No way to add back lint categories after "none" (Bug - P4)
  • JDK-8352901: No way to add back lint categories after "none" (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24227/head:pull/24227
$ git checkout pull/24227

Update a local copy of the PR:
$ git checkout pull/24227
$ git pull https://git.openjdk.org/jdk.git pull/24227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24227

View PR using the GUI difftool:
$ git pr show -t 24227

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24227.diff

Using Webrev

Link to Webrev Comment

@archiecobbs
Copy link
Contributor Author

/csr

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added rfr Pull request is ready for review csr Pull request needs approved CSR before integration labels Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@archiecobbs has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@archiecobbs please create a CSR request for issue JDK-8352612 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@archiecobbs The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Mar 25, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant