8352612: No way to add back lint categories after "none" #24227
+43
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to the
-Xlint:none
flag. Currently, it not only disables all lint categories as one would expect, but it also disables all non-mandatory warnings, period. In other words,-Xlint:none
has-nowarn
as a hidden side-effect. So for example, trying to do-Xlint:none,serial
to enable only theserial
lint category is futile: the category will be enabled but the warnings won't ever appear. This PR removes that hidden side-effect, and also clarifies some of the help output.Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24227/head:pull/24227
$ git checkout pull/24227
Update a local copy of the PR:
$ git checkout pull/24227
$ git pull https://git.openjdk.org/jdk.git pull/24227/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24227
View PR using the GUI difftool:
$ git pr show -t 24227
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24227.diff
Using Webrev
Link to Webrev Comment