8352762: Use EXACTFMT instead of expanded version where applicable

[jsikstro]

JDK-8310233 introduced the EXACTFMT macro, which is a shorthand for printing exact values using methods defined in globalDefinitions.hpp. There are currently 20 places in HotSpot which uses the expanded version of the macro, along with the "trace_page_size_params" macro that is defined and used in os.cpp.

I have replaced places that use the expanded macro(s) with EXACTFMT + EXACTFMTARGS, and also removed trace_page_size_params from os.cpp, which was essentially a redefnition of EXACTFMTARGS.

Testing: GHA, tiers 1-4

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352762: Use EXACTFMT instead of expanded version where applicable (Enhancement - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24228/head:pull/24228
$ git checkout pull/24228

Update a local copy of the PR:
$ git checkout pull/24228
$ git pull https://git.openjdk.org/jdk.git pull/24228/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24228

View PR using the GUI difftool:
$ git pr show -t 24228

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24228.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jsikstro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jsikstro This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352762: Use EXACTFMT instead of expanded version where applicable

Reviewed-by: dholmes, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 52 new commits pushed to the master branch:

• 66b5dba: 8350988: Consolidate Identity of self-inverse operations
• 1007811: 8352897: RISC-V: Change default value for UseConservativeFence
• 7853415: 8352218: RISC-V: Zvfh requires RVV
• 2483340: 8352579: Refactor CDS legacy optimization for lambda proxy classes
• 1397ee5: 8334322: Misleading values of keys in jpackage resource bundle
• 441bd12: 8352812: remove useless class and function parameter in SuspendThread impl
• e83cccf: 8352948: Remove leftover runtime_x86_32.cpp after 32-bit x86 removal
• 5672a93: 8348400: GenShen: assert(ShenandoahHeap::heap()->is_full_gc_in_progress() || (used_regions_size() <= _max_capacity)) failed: Cannot use more than capacity #
• c2a4fed: 8348907: Stress times out when is executed with ZGC
• 5392674: 8352766: Problemlist hotspot tier1 tests requiring tools that are not included in static JDK
• ... and 42 more: https://git.openjdk.org/jdk/compare/6bc480358c80b0a1a94b5ca5f4b7ff2d84ce8e37...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jsikstro The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[jsikstro]

/label add hotspot-gc
/label add hotspot-runtime

[openjdk]

@jsikstro
The hotspot-gc label was successfully added.

[openjdk]

@jsikstro
The hotspot-runtime label was successfully added.

[mlbridge]

Webrevs

• 00: Full (b1a85ea2)

[dholmes-ora]

Paging @tstuefe ! Thomas added EXACTFMT in JDK-8310233 and did not use it for some of the places where you are now using it. Despite being a reviewer of Thomas's change, I'm not at all sure when EXACTFMT should be used. But this looks good.

[dholmes-ora]

This looks very consistent and reasonable to me.

[tstuefe]

Neat, thank you. Looks good.

[jsikstro]

Thank you for the reviews! @dholmes-ora @tstuefe
/integrate

[openjdk]

Going to push as commit dc5c414.
Since your change was applied there have been 66 commits pushed to the master branch:

• 2eeda64: 8325132: CDS: Make sure the ArchiveRelocationMode is always printed in the log
• 50ac24e: 8351593: [JMH] test PhoneCode.Bulk reports NPE exception
• 79824c3: 8352184: Jtreg tests using CommandLineOptionTest.getVMTypeOption() and optionsvalidation.JVMOptionsUtils fail on static JDK
• c50a0a1: 8352508: [Redo] G1: Pinned regions with pinned objects only reachable by native code crash VM
• 89e5c42: 8294954: Remove superfluous ResourceMarks when using LogStream
• 41f3eea: 8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI
• e2cd70a: 8351151: Clean up x86 template interpreter after 32-bit x86 removal
• b990780: 8352393: AIX: Problem list serviceability/attach/AttachAPIv2/StreamingOutputTest.java
• 927aeb2: 8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself
• 0bfa636: 8352426: RelocIterator should correctly handle nullptr address of relocation data
• ... and 56 more: https://git.openjdk.org/jdk/compare/6bc480358c80b0a1a94b5ca5f4b7ff2d84ce8e37...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jsikstro Pushed as commit dc5c414.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.