Block making AI chat calls for pending statuses #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR prevents new AI chat requests from being submitted while a previous request is still pending or streaming.
- Adds a
statusprop to chat containers to be forwarded to the input component - Introduces a shared
ChatStatusconstant inai-chat-input.tsxand uses it to disable the send button - Removes duplicate
ChatStatusdefinitions in React UI and imports the shared constant
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/ui-components/src/components/ai-chat-container/step-settings-ai-chat-container.tsx | Pass status down to the input component |
| packages/ui-components/src/components/ai-chat-container/ai-chat-input.tsx | Export ChatStatus, add status prop, disable send button on pending statuses |
| packages/ui-components/src/components/ai-chat-container/ai-assistant-chat-container.tsx | Pass status down to the input component |
| packages/react-ui/src/app/features/builder/ai-chat/step-settings-ai-conversation.tsx | Remove local ChatStatus, import from shared UI package |
| packages/react-ui/src/app/features/ai/ai-assistant-conversation.tsx | Remove local ChatStatus, import from shared UI package |
Comments suppressed due to low confidence (3)
packages/ui-components/src/components/ai-chat-container/ai-chat-input.tsx:17
- [nitpick] The prop name
statusis quite generic; consider renaming it tochatStatusfor clarity and to avoid naming collisions in parent components.
status?: string;
packages/ui-components/src/components/ai-chat-container/ai-chat-input.tsx:60
- Add unit or integration tests to verify that the send button is properly disabled when
statusisSTREAMINGorSUBMITTED, and enabled otherwise.
disabled={
packages/ui-components/src/components/ai-chat-container/step-settings-ai-chat-container.tsx:288
- Ensure the
StepSettingsAiChatContainerprops interface includesstatus, otherwise TypeScript will report a missing prop error when forwarding it toAiChatInput.
status={status}
packages/ui-components/src/components/ai-chat-container/ai-chat-input.tsx
Outdated
Show resolved
Hide resolved
cezudas
reviewed
Jun 27, 2025
| export type AiChatInputProps = { | ||
| className?: string; | ||
| placeholder?: string; | ||
| status?: string; |
There was a problem hiding this comment.
I think Copilot's remark is legit, I think it should not be string, but a type based on ChatStatus
|
cezudas
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes OPS-1740.
https://www.loom.com/share/a4ec27b03b8e4a91ad6330322fb9ed4d?sid=29b0ad50-7e01-4a41-8277-4f01e18bc1a3