BUG : fix Series.mode throwing exception with dropna=False and no nul… #58931
Conversation
| @@ -1093,7 +1093,13 @@ def _mode(self, dropna: bool = True) -> Self: | |||
| result = mode(self._data, dropna=dropna, mask=self._mask) | |||
| res_mask = np.zeros(result.shape, dtype=np.bool_) | |||
| else: | |||
| result, res_mask = mode(self._data, dropna=dropna, mask=self._mask) | |||
| res_tuple = mode(self._data, dropna=dropna, mask=self._mask) | |||
There was a problem hiding this comment.
Is it possible to make the return type of mode consistent throughout the code base so we don't have a check like this?
There was a problem hiding this comment.
I did a little investigation earlier and res_mask seems to be incorrect here if the series has pd.NA in it.
There was a problem hiding this comment.
With the mode return type consistency, it's called in a bunch of other places using the return with no mask, so not sure if it's worth changing it to then have to uglify other usages to result, _ = mode(...), return mode(...)[0]
There was a problem hiding this comment.
I agree it's good to have a consistent return type here. result, _ = mode(...) is not ugly to me.
mroeschke
added
the
NA - MaskedArrays
| @@ -1093,7 +1093,13 @@ def _mode(self, dropna: bool = True) -> Self: | |||
| result = mode(self._data, dropna=dropna, mask=self._mask) | |||
| res_mask = np.zeros(result.shape, dtype=np.bool_) | |||
| else: | |||
| result, res_mask = mode(self._data, dropna=dropna, mask=self._mask) | |||
| res_tuple = mode(self._data, dropna=dropna, mask=self._mask) | |||
There was a problem hiding this comment.
I did a little investigation earlier and res_mask seems to be incorrect here if the series has pd.NA in it.
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
…ls present (#58926)
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Fixes edge case in #58926 with a series of nullable dtypes but no null values.