fix(storage-gcs): return error status 404 on file not found instead of 500 #11746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akhrarovsaid
changed the title
paulpopus
approved these changes
Jun 11, 2025
paulpopus
changed the title
|
🚀 This is included in version v3.43.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In a similar vein to #11734, #11733, #10327 - this PR returns a 404 in the response when a file is not found while using the
storage-gcsadapter. Currently a 500 is returned.Why?
To return the correct error level in the response when a file is not found when using
storage-gcs.How?
The GCS nodejs library exposes the
ApiErroras a general error - these changes check that the caught error is an instance of this class and if the provided code is a404.