perf(richtext-lexical): improve typing performance while toolbars are enabled #12669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpopus
previously approved these changes
Jun 3, 2025
SimYunSup
reviewed
Jun 4, 2025
packages/richtext-lexical/src/features/toolbars/shared/ToolbarDropdown/index.tsx
Outdated
Show resolved
Hide resolved
GermanJablo
approved these changes
Jun 5, 2025
|
🚀 This is included in version v3.42.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lexical fixed and inline toolbars do active / enabled state calculations for toolbar buttons / dropdowns on every keystroke. This can incur a performance hit on slow machines.
This PR
useDeferredValueandrequestIdleCallbackuseEffects to reduce re-renderingBefore (20x cpu throttling)
Screenshot.2025-06-03.at.14.51.42.mp4
After (20x cpu throttling)
Screenshot.2025-06-03.at.14.50.01.mp4