fix(ui): save nested richtext inside inlineBlock #12773
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the
setTimeoutnot only doesn't break any tests, but it also fixes the linked issue.The long comment above the if statement was added in #5460 and explains why the if statement is necessary GIVEN the existence of the
setTimeout, but thesetTimeoutwas introduced earlier because the button apparently didn't work.It seems to work now without the
setTimeout, because otherwise the tests wouldn't even pass. I also tested it manually, and it works fine.Fixes #12687